mirror of
https://github.com/mbierlee/mirage-config.git
synced 2024-11-14 20:34:00 +01:00
Support exclamation marks as comments in Java properties
This commit is contained in:
parent
7f65ef9d9e
commit
b82b50a16f
|
@ -13,8 +13,8 @@ module mirage.java;
|
|||
|
||||
import mirage.config : ConfigDictionary;
|
||||
import mirage.keyvalue : KeyValueConfigFactory, SupportHashtagComments, SupportSemicolonComments,
|
||||
SupportSections, NormalizeQuotedValues, SupportEqualsSeparator, SupportColonSeparator,
|
||||
SupportKeysWithoutValues;
|
||||
SupportExclamationComments, SupportSections, NormalizeQuotedValues, SupportEqualsSeparator,
|
||||
SupportColonSeparator, SupportKeysWithoutValues;
|
||||
|
||||
/**
|
||||
* Creates configuration files from Java properties.
|
||||
|
@ -22,6 +22,7 @@ import mirage.keyvalue : KeyValueConfigFactory, SupportHashtagComments, SupportS
|
|||
class JavaPropertiesFactory : KeyValueConfigFactory!(
|
||||
SupportHashtagComments.yes,
|
||||
SupportSemicolonComments.no,
|
||||
SupportExclamationComments.yes,
|
||||
SupportSections.no,
|
||||
NormalizeQuotedValues.no,
|
||||
SupportEqualsSeparator.yes,
|
||||
|
@ -65,7 +66,7 @@ version (unittest) {
|
|||
di.bla=two
|
||||
meh: very
|
||||
much = not much
|
||||
much: much
|
||||
much: much !important!!!!!!!!
|
||||
empty
|
||||
");
|
||||
|
||||
|
|
|
@ -21,6 +21,7 @@ import std.typecons : Flag;
|
|||
|
||||
alias SupportHashtagComments = Flag!"SupportHashtagComments";
|
||||
alias SupportSemicolonComments = Flag!"SupportSemicolonComments";
|
||||
alias SupportExclamationComments = Flag!"SupportExclamationComments";
|
||||
alias SupportSections = Flag!"SupportSections";
|
||||
alias NormalizeQuotedValues = Flag!"NormalizeQuotedValues";
|
||||
alias SupportEqualsSeparator = Flag!"SupportEqualsSeparator";
|
||||
|
@ -34,6 +35,7 @@ alias SupportKeysWithoutValues = Flag!"SupportKeysWithoutValues";
|
|||
class KeyValueConfigFactory(
|
||||
SupportHashtagComments supportHashtagComments = SupportHashtagComments.no,
|
||||
SupportSemicolonComments supportSemicolonComments = SupportSemicolonComments.no,
|
||||
SupportExclamationComments supportExclamationComments = SupportExclamationComments.no,
|
||||
SupportSections supportSections = SupportSections.no,
|
||||
NormalizeQuotedValues normalizeQuotedValues = NormalizeQuotedValues.no,
|
||||
SupportEqualsSeparator supportEqualsSeparator = SupportEqualsSeparator.no,
|
||||
|
@ -58,19 +60,18 @@ class KeyValueConfigFactory(
|
|||
foreach (size_t index, string line; lines) {
|
||||
auto processedLine = line;
|
||||
|
||||
if (supportHashtagComments) {
|
||||
auto commentPosition = processedLine.indexOf('#');
|
||||
void replaceComments(bool isTypeSupported, char commentToken) {
|
||||
if (isTypeSupported) {
|
||||
auto commentPosition = processedLine.indexOf(commentToken);
|
||||
if (commentPosition >= 0) {
|
||||
processedLine = processedLine[0 .. commentPosition];
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if (supportSemicolonComments) {
|
||||
auto commentPosition = processedLine.indexOf(';');
|
||||
if (commentPosition >= 0) {
|
||||
processedLine = processedLine[0 .. commentPosition];
|
||||
}
|
||||
}
|
||||
replaceComments(supportHashtagComments, '#');
|
||||
replaceComments(supportSemicolonComments, ';');
|
||||
replaceComments(supportExclamationComments, '!');
|
||||
|
||||
processedLine = processedLine.strip;
|
||||
|
||||
|
@ -127,6 +128,7 @@ version (unittest) {
|
|||
class TestKeyValueConfigFactory : KeyValueConfigFactory!(
|
||||
SupportHashtagComments.no,
|
||||
SupportSemicolonComments.no,
|
||||
SupportExclamationComments.no,
|
||||
SupportSections.no,
|
||||
NormalizeQuotedValues.no,
|
||||
SupportEqualsSeparator.yes,
|
||||
|
@ -151,6 +153,7 @@ version (unittest) {
|
|||
auto config = new KeyValueConfigFactory!(
|
||||
SupportHashtagComments.yes,
|
||||
SupportSemicolonComments.yes,
|
||||
SupportExclamationComments.yes,
|
||||
SupportSections.no,
|
||||
NormalizeQuotedValues.no,
|
||||
SupportEqualsSeparator.yes,
|
||||
|
@ -158,6 +161,7 @@ version (unittest) {
|
|||
)().parseConfig("
|
||||
# this is a comment
|
||||
; this is another comment
|
||||
! this then is also a comment!
|
||||
iamset=true
|
||||
");
|
||||
|
||||
|
@ -181,6 +185,7 @@ version (unittest) {
|
|||
auto config = new KeyValueConfigFactory!(
|
||||
SupportHashtagComments.no,
|
||||
SupportSemicolonComments.no,
|
||||
SupportExclamationComments.no,
|
||||
SupportSections.no,
|
||||
NormalizeQuotedValues.no,
|
||||
SupportEqualsSeparator.yes,
|
||||
|
@ -223,6 +228,7 @@ version (unittest) {
|
|||
auto config = new KeyValueConfigFactory!(
|
||||
SupportHashtagComments.yes,
|
||||
SupportSemicolonComments.yes,
|
||||
SupportExclamationComments.yes,
|
||||
SupportSections.no,
|
||||
NormalizeQuotedValues.no,
|
||||
SupportEqualsSeparator.yes,
|
||||
|
@ -230,10 +236,12 @@ version (unittest) {
|
|||
)().parseConfig("
|
||||
server=localhost #todo: change me. default=localhost when not set.
|
||||
port=9876; I think this port = right?
|
||||
timeout=36000 ! pretty long!
|
||||
");
|
||||
|
||||
assert(config.get("server") == "localhost");
|
||||
assert(config.get("port") == "9876");
|
||||
assert(config.get("timeout") == "36000");
|
||||
}
|
||||
|
||||
@("Support sections when enabled")
|
||||
|
@ -241,6 +249,7 @@ version (unittest) {
|
|||
auto config = new KeyValueConfigFactory!(
|
||||
SupportHashtagComments.no,
|
||||
SupportSemicolonComments.yes,
|
||||
SupportExclamationComments.no,
|
||||
SupportSections.yes,
|
||||
NormalizeQuotedValues.no,
|
||||
SupportEqualsSeparator.yes,
|
||||
|
@ -275,6 +284,7 @@ version (unittest) {
|
|||
auto config = new KeyValueConfigFactory!(
|
||||
SupportHashtagComments.yes,
|
||||
SupportSemicolonComments.no,
|
||||
SupportExclamationComments.no,
|
||||
SupportSections.no,
|
||||
NormalizeQuotedValues.yes,
|
||||
SupportEqualsSeparator.yes,
|
||||
|
@ -299,6 +309,7 @@ version (unittest) {
|
|||
auto config = new KeyValueConfigFactory!(
|
||||
SupportHashtagComments.no,
|
||||
SupportSemicolonComments.no,
|
||||
SupportExclamationComments.no,
|
||||
SupportSections.no,
|
||||
NormalizeQuotedValues.no,
|
||||
SupportEqualsSeparator.yes,
|
||||
|
|
Loading…
Reference in a new issue