mirrors/clevo-keyboard
mirrors/clevo-keyboard
1
0
Fork 0
mirror of https://github.com/wessel-novacustom/clevo-keyboard.git synced 2024-11-15 03:34:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add doc: meaningfull variable names

Browse source
This commit is contained in:
Richard Sailer 2019-08-18 05:49:12 +02:00
parent 5c64a75ec0
commit 0df6f7362b
1 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/tuxedo_keyboard.c
View file

@ -112,13 +112,15 @@ struct platform_device *tuxedo_platform_device;
static struct input_dev *tuxedo_input_device;
// Param Validators
static int blinking_pattern_id_validator(const char *val, const struct kernel_param *kp);
static int blinking_pattern_id_validator(const char *value,
const struct kernel_param *blinking_pattern_param);
static const struct kernel_param_ops param_ops_mode_ops = {
.set = blinking_pattern_id_validator,
.get = param_get_int,
};
static int brightness_validator(const char *val, const struct kernel_param *kp);
static int brightness_validator(const char *val,
const struct kernel_param *brightness_param);
static const struct kernel_param_ops param_ops_brightness_ops = {
.set = brightness_validator,
.get = param_get_int,
@ -465,31 +467,32 @@ static ssize_t set_blinking_pattern_fs(struct device *child,
return size;
}
static int blinking_pattern_id_validator(const char *val,
const struct kernel_param *kp)
static int blinking_pattern_id_validator(const char *value,
const struct kernel_param *blinking_pattern_param)
{
int blinking_pattern = 0;
if (kstrtoint(val, 10, &blinking_pattern) != 0
if (kstrtoint(value, 10, &blinking_pattern) != 0
|| blinking_pattern < 0
|| blinking_pattern > (ARRAY_SIZE(blinking_patterns) - 1)) {
return -EINVAL;
}
return param_set_int(val, kp);
return param_set_int(value, blinking_pattern_param);
}
static int brightness_validator(const char *val, const struct kernel_param *kp)
static int brightness_validator(const char *value,
const struct kernel_param *brightness_param)
{
int brightness = 0;
if (kstrtoint(val, 10, &brightness) != 0
if (kstrtoint(value, 10, &brightness) != 0
|| brightness < BRIGHTNESS_MIN
|| brightness > BRIGHTNESS_MAX) {
return -EINVAL;
}
return param_set_int(val, kp);
return param_set_int(value, brightness_param);
}
static void tuxedo_wmi_notify(u32 value, void *context)