mirrors/clevo-keyboard
mirrors/clevo-keyboard
1
0
Fork 0
mirror of https://github.com/wessel-novacustom/clevo-keyboard.git synced 2024-11-15 03:34:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

uniwill_wmi: Restructure busy wait loop to include delay before read

Browse source
This commit is contained in:
Christoffer Sandberg 2023-02-13 12:13:04 +01:00
parent 2a3c59b06f
commit 230acf3940
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/uniwill_wmi.c
View file

@ -124,6 +124,7 @@ static u32 uw_ec_read_addr_direct(u8 addr_low, u8 addr_high, union uw_ec_read_re
{ {
u32 result; u32 result;
u8 tmp, count, flags; u8 tmp, count, flags;
bool ready;
mutex_lock(&uniwill_ec_lock); mutex_lock(&uniwill_ec_lock);
@ -146,10 +147,11 @@ static u32 uw_ec_read_addr_direct(u8 addr_low, u8 addr_high, union uw_ec_read_re
// Wait for ready flag // Wait for ready flag
count = UW_EC_WAIT_CYCLES; count = UW_EC_WAIT_CYCLES;
ec_read(UNIWILL_EC_REG_FLAGS, &tmp); ready = false;
while (((tmp & (1 << UNIWILL_EC_BIT_DRDY)) == 0) && count != 0) { while (!ready && count != 0) {
msleep(1); msleep(1);
ec_read(UNIWILL_EC_REG_FLAGS, &tmp); ec_read(UNIWILL_EC_REG_FLAGS, &tmp);
ready = (tmp & (1 << UNIWILL_EC_BIT_DRDY)) != 0;
count -= 1; count -= 1;
} }
@ -178,6 +180,7 @@ static u32 uw_ec_write_addr_direct(u8 addr_low, u8 addr_high, u8 data_low, u8 da
{ {
u32 result = 0; u32 result = 0;
u8 tmp, count, flags; u8 tmp, count, flags;
bool ready;
mutex_lock(&uniwill_ec_lock); mutex_lock(&uniwill_ec_lock);
@ -202,10 +205,11 @@ static u32 uw_ec_write_addr_direct(u8 addr_low, u8 addr_high, u8 data_low, u8 da
// Wait for ready flag // Wait for ready flag
count = UW_EC_WAIT_CYCLES; count = UW_EC_WAIT_CYCLES;
ec_read(UNIWILL_EC_REG_FLAGS, &tmp); ready = false;
while (((tmp & (1 << UNIWILL_EC_BIT_DRDY)) == 0) && count != 0) { while (!ready && count != 0) {
msleep(1); msleep(1);
ec_read(UNIWILL_EC_REG_FLAGS, &tmp); ec_read(UNIWILL_EC_REG_FLAGS, &tmp);
ready = (tmp & (1 << UNIWILL_EC_BIT_DRDY)) != 0;
count -= 1; count -= 1;
} }