mirrors/clevo-keyboard
mirrors/clevo-keyboard
1
0
Fork 0
mirror of https://github.com/wessel-novacustom/clevo-keyboard.git synced 2024-11-15 03:34:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

More meaningfull var names and some commments for doc purposes

Browse source
This commit is contained in:
Richard Sailer 2019-08-04 06:11:06 +02:00
parent bbb1646ff7
commit 8385cfa2df
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/tuxedo_keyboard.c
View file

@ -315,16 +315,16 @@ static void set_state(u8 state)
static ssize_t set_state_fs(struct device *child, struct device_attribute *attr, static ssize_t set_state_fs(struct device *child, struct device_attribute *attr,
const char *buffer, size_t size) const char *buffer, size_t size)
{ {
unsigned int val; unsigned int state;
int err = kstrtouint(buffer, 0, &val); int err = kstrtouint(buffer, 0, &state);
if (err) { if (err) {
return err; return err;
} }
val = clamp_t(u8, val, 0, 1); state = clamp_t(u8, state, 0, 1);
set_state(val); set_state(state);
return size; return size;
} }
@ -351,6 +351,8 @@ static int set_color_region(const char *color_string, size_t size, u32 region)
} }
if (!set_color(region, colorcode)) { if (!set_color(region, colorcode)) {
// after succesfully setting color, update our state struct
// depending on which region was changed
switch (region) { switch (region) {
case REGION_LEFT: case REGION_LEFT:
keyboard.color.left = colorcode; keyboard.color.left = colorcode;
@ -424,15 +426,15 @@ static ssize_t set_blinking_pattern_fs(struct device *child,
struct device_attribute *attr, struct device_attribute *attr,
const char *buffer, size_t size) const char *buffer, size_t size)
{ {
unsigned int val; unsigned int blinking_pattern;
int err = kstrtouint(buffer, 0, &val); int err = kstrtouint(buffer, 0, &blinking_pattern);
if (err) { if (err) {
return err; return err;
} }
val = clamp_t(u8, val, 0, ARRAY_SIZE(blinking_patterns) - 1); blinking_pattern = clamp_t(u8, blinking_pattern, 0, ARRAY_SIZE(blinking_patterns) - 1);
set_blinking_pattern(val); set_blinking_pattern(blinking_pattern);
return size; return size;
} }