mirrors/clevo-keyboard
mirrors/clevo-keyboard
1
0
Fork 0
mirror of https://github.com/wessel-novacustom/clevo-keyboard.git synced 2024-11-15 03:34:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove unnecesarry checks/ ternary expressions

Browse source
This commit is contained in:
Richard Sailer 2019-05-31 17:52:03 +02:00
parent 1b2d7ecfbf
commit b0f76c723f
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/tuxedo_keyboard.c
View file

@ -52,7 +52,7 @@ static ssize_t set_state_fs(struct device *child, struct device_attribute *attr,
set_kb_state(val); set_kb_state(val);
return ret ? : size; return size;
} }
// Sysfs Interface for the color of the left side (Color as hexvalue) // Sysfs Interface for the color of the left side (Color as hexvalue)
@ -108,6 +108,7 @@ static ssize_t show_brightness_fs(struct device *child, struct device_attribute
static ssize_t set_brightness_fs(struct device *child, struct device_attribute *attr, const char *buffer, size_t size) static ssize_t set_brightness_fs(struct device *child, struct device_attribute *attr, const char *buffer, size_t size)
{ {
unsigned int val; unsigned int val;
// hier unsigned?
int ret = kstrtouint(buffer, 0, &val); int ret = kstrtouint(buffer, 0, &val);
if (ret) if (ret)
@ -118,7 +119,7 @@ static ssize_t set_brightness_fs(struct device *child, struct device_attribute *
val = clamp_t(u8, val, BRIGHTNESS_MIN, BRIGHTNESS_MAX); val = clamp_t(u8, val, BRIGHTNESS_MIN, BRIGHTNESS_MAX);
set_brightness(val); set_brightness(val);
return ret ? : size; return size;
} }
// Sysfs Interface for the keyboard mode // Sysfs Interface for the keyboard mode
@ -140,7 +141,7 @@ static ssize_t set_mode_fs(struct device *child, struct device_attribute *attr,
val = clamp_t(u8, val, 0, ARRAY_SIZE(modes) - 1); val = clamp_t(u8, val, 0, ARRAY_SIZE(modes) - 1);
set_mode(val); set_mode(val);
return ret ? : size; return size;
} }
// Sysfs Interface for if the keyboard has extra region // Sysfs Interface for if the keyboard has extra region
@ -322,6 +323,7 @@ static int tuxedo_wmi_probe(struct platform_device *dev)
int status; int status;
status = wmi_install_notify_handler(CLEVO_EVENT_GUID, tuxedo_wmi_notify, NULL); status = wmi_install_notify_handler(CLEVO_EVENT_GUID, tuxedo_wmi_notify, NULL);
// neuer name?
TUXEDO_DEBUG("clevo_xsm_wmi_probe status: (%0#6x)", status); TUXEDO_DEBUG("clevo_xsm_wmi_probe status: (%0#6x)", status);
if (unlikely(ACPI_FAILURE(status))) if (unlikely(ACPI_FAILURE(status)))
@ -530,7 +532,7 @@ static int set_color_region(const char *buffer, size_t size, u32 region)
} }
} }
return ret ? : size; return size;
} }
static int mode_validator(const char *val, const struct kernel_param *kp) static int mode_validator(const char *val, const struct kernel_param *kp)