Fix if case logic

This commit is contained in:
Werner Sembach 2022-10-24 14:32:43 +02:00
parent dd22af9924
commit c4b7644f83

View file

@ -266,13 +266,15 @@ int clevo_leds_init(struct platform_device *dev)
clevo_kb_backlight_type = result->buffer.pointer[0x0f]; clevo_kb_backlight_type = result->buffer.pointer[0x0f];
} }
else { else {
pr_err("CLEVO_CMD_GET_SPECS return value has wrong type\n"); pr_err("CLEVO_CMD_GET_SPECS does not exist on this device or return value has wrong type, trying CLEVO_CMD_GET_BIOS_FEATURES\n");
status = -EINVAL
} }
ACPI_FREE(result); ACPI_FREE(result);
} }
else { else {
pr_notice("CLEVO_CMD_GET_SPECS does not exist on this device or failed, trying CLEVO_CMD_GET_BIOS_FEATURES\n"); pr_notice("CLEVO_CMD_GET_SPECS does not exist on this device or failed, trying CLEVO_CMD_GET_BIOS_FEATURES\n");
}
if (status) {
// check for devices <= Intel 7th gen (only white only, 3 zone RGB, or no backlight on these devices) // check for devices <= Intel 7th gen (only white only, 3 zone RGB, or no backlight on these devices)
status = clevo_evaluate_method(CLEVO_CMD_GET_BIOS_FEATURES, 0, &result_fallback); status = clevo_evaluate_method(CLEVO_CMD_GET_BIOS_FEATURES, 0, &result_fallback);
if (!status) { if (!status) {
@ -284,7 +286,7 @@ int clevo_leds_init(struct platform_device *dev)
} }
} }
else { else {
pr_notice("CLEVO_CMD_GET_BIOS_FEATURES failed\n"); pr_notice("CLEVO_CMD_GET_BIOS_FEATURES does not exist on this device or failed\n");
} }
} }
pr_debug("Keyboard backlight type: 0x%02x\n", clevo_kb_backlight_type); pr_debug("Keyboard backlight type: 0x%02x\n", clevo_kb_backlight_type);