Commit graph

527 commits

Author SHA1 Message Date
Richard Sailer e116096c4e [..]keyboard.h: remove unnecesarry includes
platform_device.h and module.h are both already included by tuxedo_keyboard.c
2019-06-04 20:07:12 +02:00
Richard Sailer 4d5998ea97 Code style, return type on same line, finally use scripts/Lindent 2019-06-04 19:32:30 +02:00
Richard Sailer d319024029 Refactor: more descriptive names for two functions 2019-06-04 19:18:06 +02:00
Richard Sailer 2d6b5ebaa4 Clean up last unneeded prototypes 2019-05-31 21:55:04 +02:00
Richard Sailer 5bf846229a Clean up a lot of other unnecesarry prototypes 2019-05-31 21:55:04 +02:00
Richard Sailer 41541a3118 Remove now useless init/exit function prototypes 2019-05-31 21:55:04 +02:00
Richard Sailer 1ce4d04425 Move sysfs attribute file managment from .h to .c
It's specific to our compilation unit, nothing to export
2019-05-31 21:53:12 +02:00
Richard Sailer 4d57e59887 Move module parameter handling from .h to .c file
Other compilation units (CUs) including this header file do not need
module parameter handling. It's specific to our CU. Header files are meant to
communicate/interface with outside CUs
2019-05-31 21:50:52 +02:00
Richard Sailer 8f827c8761 Move all static global variables from .h to .c
Static global variables are compilation unit (CU) local. Making them accessible
to each other CU that includes our .h file makes no sense, they are internal
variables of our CU, therefare, move them to our CU file. .h files are for
"interfaces" to other CUs
2019-05-31 21:24:48 +02:00
Richard Sailer 80fd1b3ee3 Move all the static function declarations from .h to .c
Making a function static means "this function is compilation-unit-locale and
cannot be used (linked to) by others".

Putting a function prototype p into a header file h means every other module m
that includes h can call p.

Putting a static function prototype into a header file means "you can call this,
but you can not call this" which makes no sense. All this prototypes all only
needed compilation unit internally (and should only be used so). This commit
moves them where they belong. And subsequent commits will clean them up
because most are not necesarry in the .c file.
2019-05-31 21:16:10 +02:00
Richard Sailer 41623907ad Convert project to Linux Kernel Coding style using GNU indent
indent -kr -i8 -ts8 -sob -l80 -ss -bs -psl tuxedo_keyboard.*
2019-05-31 20:43:13 +02:00
Richard Sailer b0f76c723f Remove unnecesarry checks/ ternary expressions 2019-05-31 20:43:13 +02:00
Christian Loritz 1b2d7ecfbf
Merge pull request #11 from Darael/bugfix/10-extra-region
Enable extra region when it exists, instead of when it doesn't
2019-02-07 10:51:15 +01:00
Vinothan Shankar 64ca37889f Enable extra region when it exists, instead of when it doesn't 2019-02-02 14:47:52 +00:00
Christian Loritz 92addaaa27
Merge pull request #6 from tuxedocomputers/testing
Merge pull request #5 from tuxedocomputers/master
2018-08-20 18:25:10 +02:00
Christian Loritz 6ab61fda0a
Merge pull request #5 from tuxedocomputers/master
Master
2018-08-20 18:23:56 +02:00
Christian Loritz f22b318e27
Merge pull request #4 from pointhi/var_fix
Fix DKMS: Variable specified in Makefile is KDIR, not KERNELDIR
2018-08-20 18:21:41 +02:00
Christian Loritz 9057b951fb
Merge pull request #3 from Brainiarc7/patch-2
Update build instructions
2018-08-20 18:14:49 +02:00
Thomas Pointhuber c5db7b4115 Fix DKMS: Variable specified in Makefile is KDIR, not KERNELDIR 2018-07-17 16:13:16 +02:00
Dennis E. Mungai a96de8b994
Update build instructions
With warnings on DKMS builds (mention the potential for vermagic conflicts if step 1 & 2 are done on the same build), and recommend skipping straight to the DKMS option on systems where DKMS is present.

Future proposal: Create a makefile to automate the DKMS setup in one step.
2018-06-29 00:18:03 +03:00
Christian Loritz 03af55febd
Merge pull request #2 from tuxedocomputers/testing
Merge into master
2018-06-28 11:43:05 +02:00
Christian Loritz 345aad4b2e
Merge pull request #1 from Brainiarc7/patch-1
The /extra module target is invalid on current kernels
2018-06-28 11:13:30 +02:00
Dennis E. Mungai 24097f1480
The /extra module target is invalid on current kernels
The previous installation target is invalid on current kernels and the module could not be loaded.
This proposal fixes that.
2018-06-28 11:54:12 +03:00
cloritz be4dcb3eab Add Year in Copyright 2018-06-27 09:13:41 +02:00
Christian Loritz 2f922ce8f4 Update README.md 2018-06-08 11:59:16 +02:00
Christian Loritz 4ceede6545 Update README.md 2018-06-08 11:57:52 +02:00
Christian Loritz 134c6d9831 Initial commit 2018-06-08 11:56:32 +02:00