Richard Sailer
27aafcf1fd
refactor: set_color_region() -> set_color_string_region()
2019-08-19 05:29:54 +02:00
Richard Sailer
06bb6801df
kbd_led_state_t: add whole_kbd_color member
2019-08-19 05:28:46 +02:00
Richard Sailer
68eb899f71
Move color list to other global vars + make it static + add comments
2019-08-18 06:28:06 +02:00
Richard Sailer
690b43987a
blinking_pattern --> blinking_pattern_t
2019-08-18 06:12:11 +02:00
Richard Sailer
f6c08bf036
doc: meaningfull var names: state --> enabled
2019-08-18 06:09:03 +02:00
Richard Sailer
6c80892b31
Move all struct type definitions to the top
2019-08-18 06:03:47 +02:00
Richard Sailer
efe641bb42
doc, better names: keyboard --> kbd_led_state
2019-08-18 05:59:24 +02:00
Richard Sailer
6e72e954e5
Add own struct type for kbd_led_state
2019-08-18 05:55:43 +02:00
Richard Sailer
0df6f7362b
Add doc: meaningfull variable names
2019-08-18 05:49:12 +02:00
Richard Sailer
5c64a75ec0
Consistent terminology: Section --> Region
2019-08-12 22:26:58 +02:00
Richard Sailer
8ea156a95a
Refactor: Buffer --> color_string
2019-08-12 18:34:41 +02:00
Richard Sailer
79eb89923e
Declare, define and initialize data structure for avail. kbd colors
2019-08-06 01:53:36 +02:00
Richard Sailer
8385cfa2df
More meaningfull var names and some commments for doc purposes
2019-08-04 06:11:06 +02:00
Richard Sailer
bbb1646ff7
Some comments and better formatting
2019-08-04 04:33:28 +02:00
Richard Sailer
0a98818376
set_color_region(): more meaningfull variable names
2019-08-04 04:33:00 +02:00
Richard Sailer
4c8fb9937f
Refactoring: more meaningfull local variable names
2019-08-04 04:10:59 +02:00
Richard Sailer
2071710a71
Make central data structure blinking_pattern an own data type
2019-08-04 04:04:24 +02:00
Richard Sailer
4f0cb95266
easier names: sysfs attribute --> sysfs attribute file
2019-08-04 03:30:06 +02:00
Richard Sailer
ff7eacc2ce
Minor refactoring and cleanups
2019-08-04 02:58:15 +02:00
Richard Sailer
a493b1d572
Remove unused macro
2019-08-04 02:35:42 +02:00
Richard Sailer
c41f8febc2
Finalize module internal refactoring: mode --> blinking_pattern
2019-08-04 02:33:48 +02:00
Richard Sailer
edd7b4fb24
Move simple macro up to avoid compiler warning
2019-08-04 01:28:08 +02:00
Richard Sailer
1dcb5d2a03
Merge header with module code since it's local and of no use to other modules
2019-08-04 01:15:57 +02:00
Richard Sailer
6b6de61885
New default keyboard color: white
2019-06-06 17:14:30 +02:00
Richard Sailer
218dce4cf9
.h: Minor cleanup
2019-06-06 17:14:30 +02:00
Richard Sailer
a95f9e51e1
Refactor several symbol names: mode --> blinking_pattern to be more descriptive
2019-06-06 17:13:54 +02:00
Richard Sailer
2506b60a3a
.c: formatting, readability and some small, isomorph code simplifications
2019-06-04 21:55:56 +02:00
Richard Sailer
eb89278121
[..]keyboard.h: Remove inclusion of list.h
...
It's nowhere needed in .h or .c, whole module builds fine without it
2019-06-04 20:10:59 +02:00
Richard Sailer
e116096c4e
[..]keyboard.h: remove unnecesarry includes
...
platform_device.h and module.h are both already included by tuxedo_keyboard.c
2019-06-04 20:07:12 +02:00
Richard Sailer
4d5998ea97
Code style, return type on same line, finally use scripts/Lindent
2019-06-04 19:32:30 +02:00
Richard Sailer
d319024029
Refactor: more descriptive names for two functions
2019-06-04 19:18:06 +02:00
Richard Sailer
2d6b5ebaa4
Clean up last unneeded prototypes
2019-05-31 21:55:04 +02:00
Richard Sailer
5bf846229a
Clean up a lot of other unnecesarry prototypes
2019-05-31 21:55:04 +02:00
Richard Sailer
41541a3118
Remove now useless init/exit function prototypes
2019-05-31 21:55:04 +02:00
Richard Sailer
1ce4d04425
Move sysfs attribute file managment from .h to .c
...
It's specific to our compilation unit, nothing to export
2019-05-31 21:53:12 +02:00
Richard Sailer
4d57e59887
Move module parameter handling from .h to .c file
...
Other compilation units (CUs) including this header file do not need
module parameter handling. It's specific to our CU. Header files are meant to
communicate/interface with outside CUs
2019-05-31 21:50:52 +02:00
Richard Sailer
8f827c8761
Move all static global variables from .h to .c
...
Static global variables are compilation unit (CU) local. Making them accessible
to each other CU that includes our .h file makes no sense, they are internal
variables of our CU, therefare, move them to our CU file. .h files are for
"interfaces" to other CUs
2019-05-31 21:24:48 +02:00
Richard Sailer
80fd1b3ee3
Move all the static function declarations from .h to .c
...
Making a function static means "this function is compilation-unit-locale and
cannot be used (linked to) by others".
Putting a function prototype p into a header file h means every other module m
that includes h can call p.
Putting a static function prototype into a header file means "you can call this,
but you can not call this" which makes no sense. All this prototypes all only
needed compilation unit internally (and should only be used so). This commit
moves them where they belong. And subsequent commits will clean them up
because most are not necesarry in the .c file.
2019-05-31 21:16:10 +02:00
Richard Sailer
41623907ad
Convert project to Linux Kernel Coding style using GNU indent
...
indent -kr -i8 -ts8 -sob -l80 -ss -bs -psl tuxedo_keyboard.*
2019-05-31 20:43:13 +02:00
Richard Sailer
b0f76c723f
Remove unnecesarry checks/ ternary expressions
2019-05-31 20:43:13 +02:00
Vinothan Shankar
64ca37889f
Enable extra region when it exists, instead of when it doesn't
2019-02-02 14:47:52 +00:00
cloritz
be4dcb3eab
Add Year in Copyright
2018-06-27 09:13:41 +02:00
Christian Loritz
134c6d9831
Initial commit
2018-06-08 11:56:32 +02:00
